Repository navigation
zlib: strictly validate Zstd pledgedSrcSize - #64604
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
Archkon
marked this pull request as draft
July 19, 2026 16:18
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64604 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.02%
==========================================
Files 741 741
Lines 242196 242106 -90
Branches 45606 45587 -19
==========================================
- Hits 218246 218219 -27
+ Misses 15438 15383 -55
+ Partials 8512 8504 -8
🚀 New features to boost your workflow:
|
This comment was marked as spam.
This comment was marked as spam.
hybrist
reviewed
Jul 22, 2026
pledgedSrcSize represents an exact byte count. Reject values that are not non-negative safe integers instead of silently ignoring or coercing them through IntegerValue(). Apply the same validation to zlib/iter and retain a native validation check for internal callers. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Ethan-Arrowood
approved these changes
Jul 23, 2026
Ethan-Arrowood
left a comment
Contributor
There was a problem hiding this comment.
LGTM - since this is an experimental API I think its safe to be a patch.
Collaborator
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
This looks like an infra issue? |
Collaborator
hybrist
approved these changes
Jul 23, 2026
Collaborator
|
Landed in de6eeec |
Fixes: #64603