Repository navigation
stream: honor AbortSignal in Writer.end() - #64727
Merged
nodejs-github-bot merged 1 commit intoAug 2, 2026
Merged
Conversation
Reject Writer.end() when its signal is already aborted without closing the writer. For push writers, reject the pending operation if the signal aborts while buffered data drains, while allowing the graceful close to continue. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64727 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.01%
==========================================
Files 743 743
Lines 242412 242440 +28
Branches 45655 45660 +5
==========================================
+ Hits 218510 218568 +58
+ Misses 15403 15391 -12
+ Partials 8499 8481 -18
🚀 New features to boost your workflow:
|
Fixes: #64726
This change makes
end()reject withsignal.reasonwhen passed apre-aborted signal, without closing the writer. For push writers, aborting
the signal while buffered data is draining rejects that
end()operationwhile allowing the underlying graceful close to continue.
Assisted-by: codex:gpt-5.6-sol