Skip to content

benchmark: add --csv option to compare.js with --analyze - #65922

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/bench-compare-csv
Closed

jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/bench-compare-csv

Conversation

@jasnell

@jasnell jasnell commented Sep 9, 2026

Copy link
Copy Markdown
Member

Add a --csv {filename} option to benchmark/compare.js to capture the CSV when the --analyze option is used

@nodejs-github-bot

ghost commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 9, 2026
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 520b0e2 to df6708b Compare September 9, 2026 01:27
@codecov

ghost commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (dc3b46f) to head (c9c6a65).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65922      +/-   ##
==========================================
- Coverage   89.99%   89.99%   -0.01%     
==========================================
  Files         785      785              
  Lines      269282   269282              
  Branches    51296    51285      -11     
==========================================
- Hits       242348   242335      -13     
- Misses      17445    17447       +2     
- Partials     9489     9500      +11     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread benchmark/compare.js Resolved
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from df6708b to 2c335f8 Compare September 10, 2026 15:45
@jasnell

ghost commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

ok, had to tweak it a bit more to account for the progress display... but passing --csv - --analyze will now print the raw data followed by the analysis to process.stdout

@jasnell
jasnell requested a review from aduh95 September 10, 2026 15:47
Comment thread benchmark/compare.js Resolved
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 2c335f8 to 53b9e22 Compare September 10, 2026 16:00
@jasnell
jasnell requested a review from aduh95 September 10, 2026 16:00
Comment thread benchmark/compare.js Resolved
@jasnell
jasnell requested a review from aduh95 September 10, 2026 16:38
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from c6e0e3a to 0ad655a Compare September 10, 2026 20:53
@aduh95

ghost commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Can you address the linter failures?

@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 0ad655a to 363ebf9 Compare September 10, 2026 21:52
Comment thread test/parallel/test-benchmark-compare.js Resolved
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 68c4812 to 77be9bd Compare September 10, 2026 22:28
@jasnell
jasnell requested a review from aduh95 September 10, 2026 22:28
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@jasnell