Skip to content

Improving the performance of check_datasets_active, modifying unit test - #980

Merged
PGijsbers merged 4 commits into
developfrom
fix#671
Oct 29, 2020
Merged

Improving the performance of check_datasets_active, modifying unit test#980
PGijsbers merged 4 commits into
developfrom
fix#671

Conversation

@ArlindKadra

@ArlindKadra ArlindKadra commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Reference Issue

Fixes #671

What does this PR implement/fix? Explain your changes.

Improves the performance of the function check_datasets_active by querying only for the given datasets, instead of all datasets. Furthemore, the error throwing behavior can be controller by the user.

How should this PR be tested?

Existing unit test which was modified.

PGijsbers
PGijsbers requested changes Oct 29, 2020
View reviewed changes

@PGijsbers PGijsbers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 only two minor remarks

Comment thread doc/progress.rst Resolved
Comment thread openml/datasets/functions.py Resolved
PGijsbers
PGijsbers reviewed Oct 29, 2020
View reviewed changes
Comment thread openml/datasets/functions.py Outdated
"""
dataset_list = list_datasets(status="all")
dataset_list = list_datasets(
dataset_ids=dataset_ids,

@PGijsbers PGijsbers Oct 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change