Skip to content

Handle unknown migrations - #44

Open
ericklaus-wf wants to merge 4 commits into
rubenv:masterfrom
ericklaus-wf:handle-unknown
Open

ericklaus-wf wants to merge 4 commits into
rubenv:masterfrom
ericklaus-wf:handle-unknown

Conversation

@ericklaus-wf

Copy link
Copy Markdown

Fixes bad behavior when some migrations in the db table are unknown to the current sql-migrate instance. That might happen when one branch applies some migrations and a branch lacking those migrations tries to add some of its own.

This resolves #37 by choosing option 2 of #43.

Fixed behaviors:

  • If most recent migration is unknown, migrate up reports "nothing to do"
    • Fix: Migrations are now applied
  • If any migrations are unknown, sql-migrate status panics
    • Fix: A log warning is now emitted indicating which migrations are unknown

Some weirdness remains:

  • If the latest migration is unknown sql-migrate redo reports "nothing to do"
  • I'd rather that sql-migrate status include the fact of unknown statuses in the table it prints, rather than as separate warnings
    • Perhaps we could add a column to the sql-migrate status table (probably before the migration column) that includes a status code. Maybe "!" for "unknown" and "a" for "not applied"?

Is this course desirable? If so, I can resolve the pointed out weirdness either in this PR or later on.