Repository navigation
Conversation
…torytold#651). Importing an animated GIF as a movie (bfbdadd) made it preview and export again, but nothing pinned it: the item must probe as a GIF movie and its rendered frames must follow the file's own per-frame delays, not hold one still. Add a host integration test that imports a red/green/blue GIF and asserts each third of its duration renders the matching colour, so a regression to still-frame import is caught.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animated GIF import became a movie in
bfbdadd(crates/media/src/gif_anim.rs), which fixed #651 — but nothing locked the behaviour. This adds a host integration test that writes a red/green/blue GIF (three tenth-second frames), imports it into the wired session asaddToComp, and renders at 0.05 / 0.15 / 0.25 s, asserting each third shows the matching colour.The test fails if a GIF is probed as a still (every timestamp would render the same frame) and passes on current main, so #651 can be closed.
gifwas already a workspace dependency; added as a dev-dependency ofeffectcraft-hostto build the fixture, mirroringgif_anim.rs's own test helper.