Repository navigation
Conversation
The modern curve used g = 2^(2c), so Contrast 100 crushed 0.25 to about 8/255 while AE is about 40/255. Brightness is now a pin-black-and-white power toward white or black, then a milder S-curve g = 1 + 0.53 c, fitted to kasper9n's AE grey ramps. Legacy linear mode is unchanged. The GPU kernel matches the CPU.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #681.
Non-legacy Brightness & Contrast used
g = 2^(2c), which is much steeper than After Effects (Contrast 100 at v=0.25 was ~8/255 vs AE ~40/255).Using kasper9n's AE ramp PNGs, Clef (Jev) chose a closed-form brightness-first mild S-curve over keeping the old exponent-4 curve or a discrete 2D LUT. Brightness is a power that pins 0 and 1; contrast uses
g = 1 + 0.53 c. CPU and GPU match. B0 C-100.png was treated as a duplicate of C-50 and is not a golden.Legacy (Use Legacy) is unchanged.
Remaining: strong negative brightness (B-100 / B-150) still has a larger 8-bit error than contrast; that was accepted to ship the screenshot mismatch.