Skip to content

users: support musl - #16709

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:users-musl
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:users-musl

Conversation

@oech3

@oech3 oech3 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

part of #16639 . No unsafe cast just for users.

@oech3
oech3 force-pushed the users-musl branch 2 times, most recently from 012c8e5 to 9b08f8c Compare November 19, 2026 15:45
Comment thread Cargo.toml Resolved
Comment thread src/uu/users/src/users.rs Resolved
Comment thread src/uu/users/src/users.rs Resolved
Comment thread src/uu/users/src/users.rs Resolved
Comment thread src/uu/users/src/users.rs Resolved
Comment thread src/uu/users/src/users.rs Resolved
@codspeed

codspeed Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by ×2.4

3 warnings, 1 note

⚠️ 125 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 5 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 3 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 5 improved benchmarks
✅ 408 untouched benchmarks
⏩ 70 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Memory socket_addrs_direct[100000] 68 KB 8.6 KB ×7.9
⚡ Memory hostname_ip_lookup[100000] 66.4 KB 9.1 KB ×7.3
⚡ CPU Simulation false_consecutive_calls 350.2 ns 294.7 ns +18.85%
⚡ CPU Simulation cksum_crc 34.2 ms 33.1 ms +3.36%
⚡ CPU Simulation cksum_multiple_files 51.1 ms 49.5 ms +3.27%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:users-musl (5dc633b) with main (9311390)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (9595413) during the generation of this report, so 9311390 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/tail/follow-name is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!

@oech3
oech3 force-pushed the users-musl branch 3 times, most recently from f342cfd to eb48a58 Compare November 20, 2026 03:30
@oech3

This comment was marked as outdated.

@oech3
oech3 force-pushed the users-musl branch 3 times, most recently from 5993de7 to e0d86e2 Compare November 20, 2026 07:25
Comment thread src/uu/users/src/users.rs Resolved
Comment thread src/uucore/src/lib/features/utmpx.rs Resolved
Comment thread tests/by-util/test_users.rs Resolved
@oech3
oech3 force-pushed the users-musl branch 2 times, most recently from 912d464 to 5dc633b Compare November 20, 2026 10:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants