Repository navigation
Conversation
…ne path With -n and no key, sort parses each line once as a float to compare lines quickly. That parse always takes `.` as the decimal point, so in a locale like de_DE, where `.` groups thousands, `1.000` compared as one rather than a thousand. Lines that the parse rejected, such as `100,0`, went the locale-aware way, so the two orders disagreed: `sort -nu` let a duplicate through and `sort -nCu` accepted unsorted input. Only take the shortcut when the locale's decimal point is `.`. Fixes uutils#16735
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16735.
With
-nand no key, sort parses each whole line once as anf64so that it can compare lines quickly. That parse always takes.as the decimal point. Inde_DE, where.groups thousands,1.000compared as 1 instead of 1000. Lines the parse rejected, like100,0, took the locale-aware path, so the two disagreed:sort -nulet the second9through, andsort -nCuaccepted unsorted input.The shortcut now runs only when the locale's decimal point is
.. Other locales take the same path as-k1,1n, which already matched GNU.The new test in
test_sort.rsruns the example from the issue underLC_ALL=de_DE.UTF-8, plus a9,5vs1.000ordering case. It fails without the change and passes with it.This change was written with the help of an AI assistant (Claude); I reviewed and tested it.
🤖 Generated with Claude Code